magento/magento2#16887: [Forwardport] Fix blocked a frame with origin.#19171
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Nov 22, 2018
Merged
Conversation
Contributor
|
Hi @p-bystritsky. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
VladimirZaets
approved these changes
Nov 12, 2018
Contributor
|
Hi @VladimirZaets, thank you for the review. |
Contributor
|
Hi @p-bystritsky. Thank you for your contribution. |
|
What about clients on 2.2.* ? Will there be provided a patch to fix this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forwardport for #16887
Preconditions
<script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>Steps to reproduce
Expected result
Console without errors
Actual result
Tech notes
Time to time created iframe on following line: https://github.com/magento/magento2/blob/2.2-develop/lib/web/jquery.js#L3123
Our change add try-catch to this method, and when error appears - we just returning an empty array.